Cache GAIA profile picture URL

chrome/browser/profiles/profile_downloader_delegate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_DOWNLOADER_DELEGATE_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_DOWNLOADER_DELEGATE_H_
 #pragma once
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/string16.h"
 
 class Profile;
 class ProfileDownloader;
 
 // Reports on success or failure of Profile download. It is OK to delete the
 // |ProfileImageDownloader| instance in any of these handlers.
 class ProfileDownloaderDelegate {
  public:
   virtual ~ProfileDownloaderDelegate() {}
 
   // Returns the desired side length of the profile image. If 0, returns image
   // of the originally uploaded size.
   virtual int GetDesiredImageSideLength() = 0;
 
+  // Returns the cached URL. If the cache URL matches the new image URL
+  // the image will not be downloaded.

[Ivan Korotkov, 2011/11/30 14:35:44]

Please document what to return when there is no cached URL (empty string?)

[sail, 2011/11/30 19:00:23]

Done.

+  virtual std::string GetCachedPictureURL() = 0;

[Ivan Korotkov, 2011/11/30 14:35:44]

I think that this and the previous getter should be "const". For
GetBrowserProfile it probably makes sense to not be const since it returns
non-const Profile*.

[sail, 2011/11/30 19:00:23]

Done.

+
   // Returns the browser profile associated with this download request.
   virtual Profile* GetBrowserProfile() = 0;
 
   // Called when the download is complete. On success delegate should query
   // the downloader for values.
   virtual void OnDownloadComplete(ProfileDownloader* downloader,
                                   bool success) = 0;
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_DOWNLOADER_DELEGATE_H_