Cache GAIA profile picture URL

chrome/browser/profiles/profile_downloader.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_DOWNLOADER_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_DOWNLOADER_H_
 #pragma once
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string16.h"
 #include "chrome/browser/image_decoder.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/common/url_fetcher_delegate.h"
 #include "googleurl/src/gurl.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 class ProfileDownloaderDelegate;
 
 // Downloads user profile information. The profile picture is decoded in a
 // sandboxed process.
 class ProfileDownloader : public content::URLFetcherDelegate,
                           public ImageDecoder::Delegate,
                           public content::NotificationObserver {
  public:
+  enum PictureResult {

[Ivan Korotkov, 2011/11/30 14:35:44]

[here and in other names] "picture result" sounds somewhat unsemantical. What
about smth like PictureDownloadResult or PictureStatus?

[sail, 2011/11/30 19:00:23]

Done. Changed to PictureStatus

+    PICTURE_SUCCESS,
+    PICTURE_FAILED,
+    PICTURE_DEFAULT,
+    PICTURE_CACHED,
+  };
+
   explicit ProfileDownloader(ProfileDownloaderDelegate* delegate);
   virtual ~ProfileDownloader();
 
   // Starts downloading profile information if the necessary authorization token
   // is ready. If not, subscribes to token service and starts fetching if the
   // token is available. Should not be called more than once.
   virtual void Start();
 
   // On successful download this returns the full name of the user. For example
   // "Pat Smith".
   virtual string16 GetProfileFullName() const;
 
   // On successful download this returns the profile picture of the user.
   // For users with no profile picture set (that is, they have the default
   // profile picture) this will return an Null bitmap.
   virtual SkBitmap GetProfilePicture() const;
 
+  // Gets the profile picture result.
+  virtual PictureResult GetProfilePictureResult() const;
+
+  // Gets the URL for the profile picture.

[Ivan Korotkov, 2011/11/30 14:35:44]

Please document when (for which values of PictureResult) it makes sense to call
this one.

[sail, 2011/11/30 19:00:23]

Done.

+  virtual std::string GetProfilePictureURL() const;
+
  private:
   // Overriden from content::URLFetcherDelegate:
   virtual void OnURLFetchComplete(const content::URLFetcher* source) OVERRIDE;
 
   // Overriden from ImageDecoder::Delegate:
   virtual void OnImageDecoded(const ImageDecoder* decoder,
                               const SkBitmap& decoded_image) OVERRIDE;
   virtual void OnDecodeImageFailed(const ImageDecoder* decoder) OVERRIDE;
 
   // Overriden from content::NotificationObserver:
@@ skipping 13 matching lines @@
   // Issues the first request to get user profile image.
   void StartFetchingImage();
 
   ProfileDownloaderDelegate* delegate_;
   std::string auth_token_;
   scoped_ptr<content::URLFetcher> user_entry_fetcher_;
   scoped_ptr<content::URLFetcher> profile_image_fetcher_;
   content::NotificationRegistrar registrar_;
   string16 profile_full_name_;
   SkBitmap profile_picture_;
+  PictureResult picture_result_;
+  std::string picture_url_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileDownloader);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_DOWNLOADER_H_