Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: content/renderer/render_view_impl.cc

Issue 8742007: Prepare for didUpdateLayout moving to WebViewClient. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index a5d1e983c958dbf18024af83ceea53c54ae6cb56..c8d35b7ad626b7e5a8acc177c9059cb61547314c 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1746,6 +1746,20 @@ void RenderViewImpl::focusedNodeChanged(const WebNode& node) {
FOR_EACH_OBSERVER(RenderViewObserver, observers_, FocusedNodeChanged(node));
}
+void RenderViewImpl::didUpdateLayout() {
+ // We don't always want to set up a timer, only if we've been put in that
+ // mode by getting a |ViewMsg_EnablePreferredSizeChangedMode|
+ // message.
+ if (!send_preferred_size_changes_ || !webview())
+ return;
+
+ if (check_preferred_size_timer_.IsRunning())
+ return;
+ check_preferred_size_timer_.Start(FROM_HERE,
+ TimeDelta::FromMilliseconds(0), this,
+ &RenderViewImpl::CheckPreferredSize);
+}
+
void RenderViewImpl::navigateBackForwardSoon(int offset) {
Send(new ViewHostMsg_GoToEntryAtOffset(routing_id_, offset));
}
@@ -2877,17 +2891,7 @@ void RenderViewImpl::willReleaseScriptContext(WebFrame* frame,
}
void RenderViewImpl::didUpdateLayout(WebFrame* frame) {
- // We don't always want to set up a timer, only if we've been put in that
- // mode by getting a |ViewMsg_EnablePreferredSizeChangedMode|
- // message.
- if (!send_preferred_size_changes_ || !webview())
- return;
-
- if (check_preferred_size_timer_.IsRunning())
- return;
- check_preferred_size_timer_.Start(FROM_HERE,
- TimeDelta::FromMilliseconds(0), this,
- &RenderViewImpl::CheckPreferredSize);
+ didUpdateLayout();
}
void RenderViewImpl::CheckPreferredSize() {
@@ -3871,8 +3875,7 @@ void RenderViewImpl::OnEnablePreferredSizeChangedMode() {
// Start off with an initial preferred size notification (in case
// |didUpdateLayout| was already called).
- if (webview())
- didUpdateLayout(webview()->mainFrame());
+ didUpdateLayout();
}
void RenderViewImpl::OnDisableScrollbarsForSmallWindows(
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698