Do not create shortcuts on Windows if the "no-first-run" switch is on.

Do not create shortcuts on Windows if the "no-first-run" switch is on.

BUG=105882
TEST=see bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112355

[robertshield, 2011-11-30 20:07:48]

LGTM, with one comment to address.

Thanks for the fix :-)

http://codereview.chromium.org/8741023/diff/4001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_manager.cc (right):

http://codereview.chromium.org/8741023/diff/4001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager.cc:218: if
(!command_line.HasSwitch(switches::kNoFirstRun))
I would replace the condition with 
if (profile_shortcut_manager_.get()) {}

What we really want to do is remove the profile_shortcut_manager_ from the
observer list if it exists.

[Miranda Callahan, 2011-11-30 20:18:23]

Thanks for the quick review!

http://codereview.chromium.org/8741023/diff/4001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_manager.cc (right):

http://codereview.chromium.org/8741023/diff/4001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager.cc:218: if
(!command_line.HasSwitch(switches::kNoFirstRun))
On 2011/11/30 20:07:48, robertshield wrote:
> I would replace the condition with 
> if (profile_shortcut_manager_.get()) {}
> 
> What we really want to do is remove the profile_shortcut_manager_ from the
> observer list if it exists.

Indeed! Fixed.

[commit-bot: I haz the power, 2011-11-30 21:20:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mirandac@chromium.org/8741023/1004

[commit-bot: I haz the power, 2011-12-01 00:40:42]

Change committed as 112355