Issue 8741022: Implements Aura:: NativeWidgetPrivate::ReparentNativeView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8741022: Implements Aura:: NativeWidgetPrivate::ReparentNativeView (Closed)

Created:
9 years ago by pkotwicz

Modified:
9 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, dhollowa, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implements Aura:: NativeWidgetPrivate::ReparentNativeView BUG=102576 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113130

Patch Set 2 : Updated comment in sad_tab_observer #

Total comments: 1

Patch Set 3 : Changes as requested #

Patch Set 4 : Nicer diff #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -4 lines)			Patch
	M	chrome/browser/ui/sad_tab_observer.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
	M	ui/views/widget/native_widget_aura.cc	View	1 2	1 chunk	+23 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

http://codereview.chromium.org/8741022/diff/2001/ui/views/widget/native_widget_aura.cc File ui/views/widget/native_widget_aura.cc (right): http://codereview.chromium.org/8741022/diff/2001/ui/views/widget/native_widget_aura.cc#newcode775 ui/views/widget/native_widget_aura.cc:775: native_view->SetParent(new_parent); NativeWidgetWin does a lot more here, like sending ...

9 years ago (2011-11-30 23:24:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/8741022/7001

9 years ago (2011-12-06 00:28:59 UTC) #6

Change committed as 113130