Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5363)

Unified Diff: chrome/browser/ui/login/login_prompt.cc

Issue 8741019: Crash fix: Remove a NOTREACHED that is wrong. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/login/login_prompt.cc
diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc
index ccec8c80fa91a2137ee15ffeee5e5ccdd61e872a..58374f2321702be163578cceee67cac573867b70 100644
--- a/chrome/browser/ui/login/login_prompt.cc
+++ b/chrome/browser/ui/login/login_prompt.cc
@@ -449,7 +449,7 @@ void LoginDialogCallback(const GURL& request_url,
TabContentsWrapper* wrapper =
TabContentsWrapper::GetCurrentWrapperForContents(parent_contents);
if (!wrapper)
- NOTREACHED() << "Login dialog created for TabContents with no wrapper";
+ return;
mattm 2011/11/30 23:15:28 So if we think this is an expected behavior, shoul
James Hawkins 2011/12/01 21:37:15 Done.
PasswordManager* password_manager = wrapper->password_manager();
std::vector<PasswordForm> v;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698