Crash fix: Remove a NOTREACHED that is wrong.

chrome/browser/ui/login/login_prompt.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/login/login_prompt.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 427 matching lines @@
                          LoginHandler* handler) {
   TabContents* parent_contents = handler->GetTabContentsForLogin();
   if (!parent_contents || handler->WasAuthHandled()) {
     // The request may have been cancelled, or it may be for a renderer
     // not hosted by a tab (e.g. an extension). Cancel just in case
     // (cancelling twice is a no-op).
     handler->CancelAuth();
     return;
   }
 
+  TabContentsWrapper* wrapper =
+      TabContentsWrapper::GetCurrentWrapperForContents(parent_contents);
+  if (!wrapper) {

[asanka, 2011/12/01 21:46:39]

I'm curious how this happens in practice.  Can you add a comment explaining why?

[James Hawkins, 2011/12/01 21:48:22]

I don't know how it happens in the wild; we've gotten crash reports for it
though.

+    // Same logic as above.
+    handler->CancelAuth();
+    return;
+  }
+
   // Tell the password manager to look for saved passwords.
-  TabContentsWrapper* wrapper =
-      TabContentsWrapper::GetCurrentWrapperForContents(parent_contents);
-  if (!wrapper)
-    NOTREACHED() << "Login dialog created for TabContents with no wrapper";
-
   PasswordManager* password_manager = wrapper->password_manager();
   std::vector<PasswordForm> v;
   MakeInputForPasswordManager(request_url, auth_info, handler, &v);
   password_manager->OnPasswordFormsFound(v);
   handler->SetPasswordManager(password_manager);
 
   // The realm is controlled by the remote server, so there is no reason
   // to believe it is of a reasonable length.
   string16 elided_realm;
   ui::ElideString(UTF8ToUTF16(auth_info->realm), 120, &elided_realm);
@@ skipping 13 matching lines @@
 
 LoginHandler* CreateLoginPrompt(net::AuthChallengeInfo* auth_info,
                                 net::URLRequest* request) {
   LoginHandler* handler = LoginHandler::Create(auth_info, request);
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&LoginDialogCallback, request->url(),
                  make_scoped_refptr(auth_info), make_scoped_refptr(handler)));
   return handler;
 }