Issue 8741016: Should use startAnimation to take in account preemption strategy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8741016: Should use startAnimation to take in account preemption strategy (Closed)

Created:
9 years ago by pkotwicz

Modified:
9 years ago

Reviewers:
Ian Vollick, sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Should use startAnimation in acceleratorController in order for the animator to use the preemption strategy in starting the new animation. scheduleAnimation will queue up animations. Holding down Ctrl-Home will after a while keep on rotating well after the accelerator key has been released Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112246

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/aura_shell/shell_accelerator_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/8741016/1

9 years ago (2011-11-30 16:42:59 UTC) #4

Change committed as 112246

Expand Messages | Collapse Messages