Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 8741011: Fix BubbleDelegateView call to DisableInactiveRendering. (Closed)

Created:
9 years ago by msw
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, msw+watch_chromium.org, alicet1, tfarina, dhollowa
Visibility:
Public.

Description

Fix BubbleDelegateView call to DisableInactiveRendering. Currently, when bubbles pop up, Chrome renders as inactive/'unfocused'. Call DisableInactiveRendering on Widget::Show rather than Widget construction. BUG=98312, 98323 TEST=Showing bubbles doesn't make Chrome appear inactive/'unfocused'. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/views/bubble/bubble_delegate.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
PTAL; thanks!
9 years ago (2011-11-30 11:20:10 UTC) #1
sky
LGTM
9 years ago (2011-11-30 16:31:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8741011/1
9 years ago (2011-11-30 20:28:25 UTC) #3
commit-bot: I haz the power
9 years ago (2011-11-30 22:18:44 UTC) #4
Change committed as 112304

Powered by Google App Engine
This is Rietveld 408576698