ONC import option to chromeos tab in chrome://net-internals

chrome/browser/resources/net_internals/chromeos_view.js

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * This view displays information on ChromeOS specific features.
+ */
+var CrosView = (function() {
+  'use strict';
+
+  // We inherit from DivView.

[James Hawkins, 2011/12/02 22:08:57]

Don't use 'we' in comments; it's ambiguous.

[achuithb, 2011/12/03 00:23:32]

Done.

+  var superClass = DivView;

[James Hawkins, 2011/12/02 22:08:57]

Just use DivView directly.

[achuithb, 2011/12/03 00:23:32]

Done.

+
+  var fileContent;

[James Hawkins, 2011/12/02 22:08:57]

Are these 'private' vars?

[achuithb, 2011/12/03 00:23:32]

Yes - they are in anonymous function scope.

[James Hawkins, 2011/12/04 18:13:07]

OK. Append '_' to the name, document the vars, make sure to add @private to doc.

[achuithb, 2011/12/04 21:56:42]

Done.

+  var passcode = '';
+  function importONCFile() {
+    if (fileContent) {

[James Hawkins, 2011/12/02 22:08:57]

No braces for single-line blocks.

[achuithb, 2011/12/03 00:23:32]

Done.

+      g_browser.importONCFile(fileContent, passcode);
+    }
+  }
+
+  function setPasscode(value) {
+    passcode = value;
+    if (passcode) {
+      importONCFile();
+    }
+  }
+
+  function promptForPasscode() {
+    $(CrosView.PASSWORD_ID).hidden = false;
+    $(CrosView.PASSWORD_INPUT_ID).focus();
+    $(CrosView.PASSWORD_INPUT_ID).select();
+  }
+
+  function setFileContent(result) {
+    fileContent = result;
+    // Check if file is encrypted.
+    if (fileContent.search(/begin pgp message/i) == -1) {
+      // Not encrypted, don't need passcode.
+      importONCFile();
+    } else {
+      promptForPasscode();
+    }
+  }
+
+  function addEventListeners() {

[James Hawkins, 2011/12/02 22:08:57]

Document all of these methods.

[achuithb, 2011/12/03 00:23:32]

Done.

+    $(CrosView.IMPORT_ONC_ID).addEventListener('change', function(event) {
+      $(CrosView.PARSE_STATUS_ID).hidden = true;
+      var file = event.target.files[0];
+      var reader = new FileReader();
+      reader.onloadend = function(e) {
+        setFileContent(this.result);
+      };
+      reader.readAsText(file);
+    }, false);
+
+    $(CrosView.PASSWORD_INPUT_ID).addEventListener('change', function(event) {
+      setPasscode(this.value);
+    }, false);
+  }
+
+  function reset() {
+    fileContent = undefined;
+    passcode = '';
+    $(CrosView.PASSWORD_ID).hidden = true;
+  }
+
+  /**
+   *  @constructor

[James Hawkins, 2011/12/02 22:08:57]

@extends

[achuithb, 2011/12/03 00:23:32]

Done.

+   */
+  function CrosView() {
+    assertFirstConstructorCall(CrosView);
+
+    // Call superclass's constructor.
+    superClass.call(this, CrosView.MAIN_BOX_ID);
+
+    g_browser.addCrosONCFileParseObserver(this);
+    addEventListeners();
+  }
+
+  // ID for special HTML element in category_tabs.html
+  CrosView.TAB_HANDLE_ID = 'tab-handle-chromeos';
+
+  CrosView.MAIN_BOX_ID = 'chromeos-view-tab-content';
+  CrosView.IMPORT_ONC_ID = 'chromeos-view-import-onc';
+  CrosView.PASSWORD_ID = 'chromeos-view-password-div';
+  CrosView.PASSWORD_INPUT_ID = 'chromeos-view-onc-password';
+  CrosView.PARSE_STATUS_ID = 'chromeos-view-parse-status';
+
+  cr.addSingletonGetter(CrosView);
+
+  CrosView.prototype = {
+    // Inherit the superclass's methods.
+    __proto__: superClass.prototype,
+
+    onONCFileParse: function(status) {
+      var parseStatus = $(CrosView.PARSE_STATUS_ID);
+      parseStatus.hidden = false;
+      parseStatus.textContent = status;
+      reset();
+    }
+  };
+
+  return CrosView;
+})();