chrome/browser/resources/net_internals/chromeos_view.html - Issue 8741009: ONC import option to chromeos tab in chrome://net-internals

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/net_internals/chromeos_view.html

Issue 8741009: ONC import option to chromeos tab in chrome://net-internals (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: review feedback Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/net_internals/browser_bridge.js ('K') | « chrome/browser/resources/net_internals/category_tabs.html ('k') | chrome/browser/resources/net_internals/chromeos_view.js » ('j') | chrome/browser/resources/net_internals/chromeos_view.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Property Changes:

Added: svn:eol-style
+ LF

OLD	NEW
(Empty)
	1 <div id="chromeos-view-tab-content">

	2 <h3>Import ONC file</h3>
	James Hawkins 2011/12/02 22:08:57 Does this string need to be localized? Does this string need to be localized? achuithb 2011/12/03 00:23:32 Nope. Nothing in net-internals is. Show quoted text On 2011/12/02 22:08:57, James Hawkins wrote: > Does this string need to be localized? Nope. Nothing in net-internals is.
	3 <p><input type="file" id="chromeos-view-import-onc"/>
	James Hawkins 2011/12/02 22:08:57 Why are you using a paragraph? It's not closed bt Why are you using a paragraph? It's not closed btw. James Hawkins 2011/12/02 22:08:57 Don't close self-closing tags, here and elsewhere. Don't close self-closing tags, here and elsewhere. achuithb 2011/12/03 00:23:32 Done. Show quoted text On 2011/12/02 22:08:57, James Hawkins wrote: > Why are you using a paragraph? It's not closed btw. Done. achuithb 2011/12/03 00:23:32 Done. Show quoted text On 2011/12/02 22:08:57, James Hawkins wrote: > Don't close self-closing tags, here and elsewhere. Done.
	4 <div id="chromeos-view-password-div" hidden>

	5 This onc file appears to be encrypted. Please provide the decryption key:

	6 <br><input type="password" id="chromeos-view-onc-password"/>
	James Hawkins 2011/12/02 22:08:57 Don't use <br>. Use divs. Don't use <br>. Use divs. achuithb 2011/12/03 00:23:32 Done. Show quoted text On 2011/12/02 22:08:57, James Hawkins wrote: > Don't use <br>. Use divs. Done.
	7 </div>

	8 <div id="chromeos-view-parse-status" hidden>

	9 </div>

	10 </div>

OLD	NEW