Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 8741006: Add exports needed for glue to build as a component. (Closed)

Created:
9 years ago by Dirk Pranke
Modified:
9 years ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, darin-cc_chromium.org, mihaip+watch_chromium.org, dcheng
Visibility:
Public.

Description

Add exports needed for glue to build as a component. This adds WEBKIT_GLUE_EXPORT, WEBKIT_PLUGINS_EXPORT, and WEBKIT_EXTENSIONS_EXPORT macros that are used by the files in webkit/{glue,plugins,extensions} to show what needs to be exported from a DLL. R=darin@chromium.org BUG=98755 TEST=waterfall stays green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112748

Patch Set 1 #

Patch Set 2 : linting #

Patch Set 3 : add export files for extensions, plugins, and turn the macros off for now :) #

Patch Set 4 : merge patchset #3 to r112567 #

Patch Set 5 : rebase to r112585 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -205 lines) Patch
M webkit/extensions/v8/gc_extension.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M webkit/extensions/v8/heap_profiler_extension.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M webkit/extensions/v8/playback_extension.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M webkit/extensions/v8/profiler_extension.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
A webkit/extensions/webkit_extensions_export.h View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M webkit/glue/alt_error_page_resource_fetcher.h View 2 chunks +7 lines, -5 lines 0 comments Download
M webkit/glue/context_menu.h View 3 chunks +3 lines, -2 lines 0 comments Download
M webkit/glue/cpp_binding_example.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/cpp_bound_class.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/cpp_variant.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/dom_operations.h View 3 chunks +5 lines, -3 lines 0 comments Download
M webkit/glue/form_data.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/form_data_predictions.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/form_field.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/glue/form_field_predictions.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/gl_bindings_skia_cmd_buffer.h View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/glue/glue_serialize.h View 1 chunk +8 lines, -5 lines 0 comments Download
M webkit/glue/idb_bindings.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/glue/image_decoder.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/image_resource_fetcher.h View 2 chunks +9 lines, -7 lines 0 comments Download
M webkit/glue/multipart_response_delegate.h View 3 chunks +7 lines, -5 lines 0 comments Download
M webkit/glue/npruntime_util.h View 1 chunk +6 lines, -3 lines 0 comments Download
M webkit/glue/p2p_transport.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/password_form.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/password_form_dom_manager.h View 4 chunks +5 lines, -3 lines 0 comments Download
M webkit/glue/resource_fetcher.h View 3 chunks +5 lines, -2 lines 0 comments Download
M webkit/glue/resource_loader_bridge.h View 7 chunks +10 lines, -9 lines 0 comments Download
M webkit/glue/resource_type.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/glue/simple_webmimeregistry_impl.h View 1 chunk +4 lines, -1 line 0 comments Download
M webkit/glue/web_intent_data.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/web_intent_service_data.h View 2 chunks +5 lines, -3 lines 0 comments Download
M webkit/glue/web_io_operators.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/glue/webaccessibility.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/webclipboard_impl.h View 1 chunk +4 lines, -1 line 0 comments Download
M webkit/glue/webcookie.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/webcursor.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/webdropdata.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/webfileutilities_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/glue/webkit_glue.h View 5 chunks +31 lines, -22 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 chunks +8 lines, -0 lines 0 comments Download
A webkit/glue/webkit_glue_export.h View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.h View 2 chunks +5 lines, -1 line 0 comments Download
M webkit/glue/webmenuitem.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/webthread_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/glue/weburlloader_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/weburlrequest_extradata_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/glue/window_open_disposition.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_constants_win.h View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M webkit/plugins/npapi/plugin_group.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_host.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_lib.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/webplugin.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_impl.h View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M webkit/plugins/plugin_constants.h View 1 2 1 chunk +9 lines, -7 lines 0 comments Download
M webkit/plugins/plugin_switches.h View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/callbacks.h View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/file_path.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/host_globals.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/host_var_tracker.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/npapi_glue.h View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/npobject_var.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_module.h View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_interface_factory.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_webplugin_impl.h View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppb_broker_impl.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_chooser_impl.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_flash_menu_impl.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_flash_net_connector_impl.h View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_image_data_impl.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppb_url_request_info_impl.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/quota_file_io.h View 1 2 3 chunks +18 lines, -15 lines 0 comments Download
M webkit/plugins/ppapi/resource_helper.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/webkit_forwarding_impl.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/sad_plugin.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
A webkit/plugins/webkit_plugins_export.h View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M webkit/plugins/webplugininfo.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M webkit/plugins/webview_plugin.h View 1 2 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dirk Pranke
9 years ago (2011-11-30 21:18:41 UTC) #1
darin (slow to review)
I still would prefer a domain specific macro for webkit/{extensions,plugins}, but I won't push for ...
9 years ago (2011-11-30 21:23:12 UTC) #2
Dirk Pranke
9 years ago (2011-11-30 21:47:15 UTC) #3
Okay, it's easy enough to add the other macros.

-- Dirk

On Wed, Nov 30, 2011 at 1:23 PM,  <darin@chromium.org> wrote:
> I still would prefer a domain specific macro for
> webkit/{extensions,plugins},
> but I won't push for it.  I feel like the clustering of webkit/glue and
> webkit/plugins in a single DLL doesn't have to be expressed at the file
> level.
>
> LGTM
>
> -Darin
>
> http://codereview.chromium.org/8741006/
>

Powered by Google App Engine
This is Rietveld 408576698