Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 8741003: Revert effects of r110733 because of silent WebRTC breakage (Closed)

Created:
9 years ago by vrk (LEFT CHROMIUM)
Modified:
9 years ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org, wjia(left Chromium)
Visibility:
Public.

Description

Revert effects of r110733 because of silent WebRTC breakage The CL to delay canplaythrough (issue 8399023) broke video capture for WebRTC. This CL temporarily disables the changes in r110733 so that canplaythrough fires immediately at the beginning of playback for all media types. BUG=105163 TEST=media_unittests,test_shell_tests, wjia's media stream test page works TBR=scherkus Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M webkit/media/webmediaplayer_impl.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vrk (LEFT CHROMIUM)
Land this in the meantime until http://codereview.chromium.org/8661002/ is ready to land.
9 years ago (2011-11-30 01:47:18 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM
9 years ago (2011-11-30 01:58:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/8741003/1
9 years ago (2011-11-30 08:05:33 UTC) #3
commit-bot: I haz the power
Presubmit check for 8741003-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-11-30 08:05:36 UTC) #4
vrk (LEFT CHROMIUM)
Looks like I need OWNERS review from scherkus, but talked about this in person before ...
9 years ago (2011-11-30 08:13:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/8741003/1
9 years ago (2011-11-30 08:14:14 UTC) #6
commit-bot: I haz the power
9 years ago (2011-11-30 09:45:36 UTC) #7
Change committed as 112179

Powered by Google App Engine
This is Rietveld 408576698