Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: src/platform/vboot_reference/tests/kernel_image_tests.c

Issue 874006: Add a command line string field to verified boot kernel config image. (Closed)
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/platform/vboot_reference/tests/kernel_image_tests.c
diff --git a/src/platform/vboot_reference/tests/kernel_image_tests.c b/src/platform/vboot_reference/tests/kernel_image_tests.c
index a9005135652fc3476348809875c16a34e22db984..3cf9c4ce0ce312f2bf493f681dd1b3808542cd00 100644
--- a/src/platform/vboot_reference/tests/kernel_image_tests.c
+++ b/src/platform/vboot_reference/tests/kernel_image_tests.c
@@ -51,13 +51,7 @@ KernelImage* GenerateTestKernelImage(int firmware_sign_algorithm,
RSAProcessedKeySize(image->kernel_sign_algorithm));
/* Update correct header length. */
- image->header_len = (sizeof(image->header_version) +
- sizeof(image->header_len) +
- sizeof(image->firmware_sign_algorithm) +
- sizeof(image->kernel_sign_algorithm) +
- RSAProcessedKeySize(image->kernel_sign_algorithm) +
- sizeof(image->kernel_key_version) +
- sizeof(image->header_checksum));
+ image->header_len = GetKernelHeaderLen(image);
/* Calculate SHA-512 digest on header and populate header_checksum. */
DigestInit(&ctx, SHA512_DIGEST_ALGORITHM);
@@ -80,7 +74,8 @@ KernelImage* GenerateTestKernelImage(int firmware_sign_algorithm,
/* Populate kernel options and data with dummy data. */
image->kernel_version = kernel_version;
image->options.version[0] = 1;
- image->options.version[1] = 1;
+ image->options.version[1] = 0;
+ Memset(image->options.cmd_line, 0, sizeof(image->options.cmd_line));
image->options.kernel_len = kernel_len;
image->options.kernel_load_addr = 0;
image->options.kernel_entry_addr = 0;
« no previous file with comments | « src/platform/vboot_reference/tests/firmware_image_tests.c ('k') | src/platform/vboot_reference/utils/firmware_image.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698