Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 874006: Add a command line string field to verified boot kernel config image. (Closed)

Created:
10 years, 9 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add a command line string field to verified boot kernel config image. Also some cleanup of duplicated code. BUG=670 TEST=Existing image verification tests still pass.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -36 lines) Patch
M src/platform/vboot_reference/include/kernel_image.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/platform/vboot_reference/tests/firmware_image_tests.c View 1 chunk +1 line, -5 lines 0 comments Download
M src/platform/vboot_reference/tests/kernel_image_tests.c View 2 chunks +3 lines, -8 lines 0 comments Download
M src/platform/vboot_reference/utils/firmware_image.c View 3 chunks +3 lines, -9 lines 0 comments Download
M src/platform/vboot_reference/utils/kernel_image.c View 8 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gauravsh
10 years, 9 months ago (2010-03-13 01:46:53 UTC) #1
sosa
10 years, 9 months ago (2010-03-13 02:07:07 UTC) #2
looks good to me!

Powered by Google App Engine
This is Rietveld 408576698