Issue 874002: Stop SVNWrapper and GitWrapper from inheriting from scm.SVN and scm.GIT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 874002: Stop SVNWrapper and GitWrapper from inheriting from scm.SVN and scm.GIT. (Closed)

Created:
10 years, 9 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nasser Grainawi

CC:
chromium-reviews

Visibility:
Public.

Description

Stop SVNWrapper and GitWrapper from inheriting from scm.SVN and scm.GIT. This simplifies the unit tests and clarify what is what. Ran pychecker on a few files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41310

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -57 lines)			Patch
M	gclient.py	View	2 chunks	+4 lines, -4 lines	1 comment	Download
M	gclient_scm.py	View	26 chunks	+39 lines, -39 lines	0 comments	Download
M	scm.py	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/gclient_scm_test.py	View	2 chunks	+3 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Based off unchecked-in change http://codereview.chromium.org/878001 http://codereview.chromium.org/874002/diff/1/2 File gclient.py (right): http://codereview.chromium.org/874002/diff/1/2#newcode482 gclient.py:482: deps_to_include = list(set(deps_os_choices.itervalues())) Removes ...

10 years, 9 months ago (2010-03-11 15:29:40 UTC) #1

lgtm

Expand Messages | Collapse Messages