Remove BindStateHolder and have Bind() return a Callback<> object directly.

base/callback_internal.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/callback_internal.h"
 
 namespace base {
 namespace internal {
 
 bool CallbackBase::is_null() const {
   return bind_state_.get() == NULL;
 }
 
 void CallbackBase::Reset() {
   bind_state_ = NULL;
   polymorphic_invoke_ = NULL;
 }
 
 bool CallbackBase::Equals(const CallbackBase& other) const {
   return bind_state_.get() == other.bind_state_.get() &&
          polymorphic_invoke_ == other.polymorphic_invoke_;
 }
 
-CallbackBase::CallbackBase(InvokeFuncStorage polymorphic_invoke,
-                           scoped_refptr<BindStateBase>* bind_state)
-    : polymorphic_invoke_(polymorphic_invoke) {
-  if (bind_state) {
-    bind_state_.swap(*bind_state);
-  }
+CallbackBase::CallbackBase(BindStateBase* bind_state)
+    : bind_state_(bind_state),

[akalin, 2011/12/02 18:54:45]

This constructor should only be called with a newly-constructed bind state,
right?  Can we assert that that is so, i.e. check that bind_state->HasOneRef()
is false before we set bind_state_ to it?

[awong, 2011/12/06 00:21:12]

Added a DCHECK, though it feels slightly overkill since no one should be new-ing
a base::internal struct...

+      polymorphic_invoke_(NULL) {
 }
 
 CallbackBase::~CallbackBase() {
 }
 
 }  // namespace base
 }  // namespace internal