Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/libphonenumber/README.chromium

Issue 8736001: Pull the phone library directly. Delete old version. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/phone_number_i18n.cc ('k') | third_party/libphonenumber/cpp/CMakeLists.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libphonenumber/README.chromium
===================================================================
--- third_party/libphonenumber/README.chromium (revision 111991)
+++ third_party/libphonenumber/README.chromium (working copy)
@@ -2,7 +2,7 @@
Short Name: libphonenumber
URL: http://libphonenumber.googlecode.com/svn/trunk/
Version: unknown
-Revision: 277
+Revision: 403
Security Critical: yes
This directory contains the source code of International Phone Number Library
@@ -18,14 +18,10 @@
libphonenumber.gyp
README.chromium
-Until the changes are upstreamed library is included directly, with patches
-in patches/version277.patch and patches/version277a.patch applied.
-
-The folders included in our repository for now are
- cpp/
- resource/
-
-TODO(georgey) : remove following lines when updated to version after 186
- cpp/src/phonelibutil.cc made icu::Transliteration member of PhoneUtil
- to improve performance, Not needed in recent versions.
-
+The library is mapped through the DEPS file into src/ folder. To update:
+1. Get the latest version number from
+ http://code.google.com/p/libphonenumber/source/list
+2. Locally update this file and DEPS.
+3. run 'gclient sync'
+4. Adjust libphonenumber.gyp if necessary.
+5. Verify that all compiles and all of the tests are successfull.
« no previous file with comments | « chrome/browser/autofill/phone_number_i18n.cc ('k') | third_party/libphonenumber/cpp/CMakeLists.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698