third_party/libphonenumber/patches/version277a.patch - Issue 8736001: Pull the phone library directly. Delete old version.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libphonenumber/patches/version277a.patch

Issue 8736001: Pull the phone library directly. Delete old version. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 diff -Naur src-orig/default_logger.h src/default_logger.h

2 --- src-orig/default_logger.h 2011-07-02 16:27:58.000000000 -0700

3 +++ src/default_logger.h 2011-07-02 16:28:29.000000000 -0700

4 @@ -17,6 +17,8 @@

5 #ifndef I18N_PHONENUMBERS_DEFAULT_LOGGER_H_

6 #define I18N_PHONENUMBERS_DEFAULT_LOGGER_H_

7

8 +#include <stdio.h>

9 +

10 #include <string>

11

12 #include "logger.h"

13 @@ -45,7 +47,7 @@

14 struct ConvertToString<int> {

15 static inline string DoWork(const int& n) {

16 char buffer[16];

17 - std::snprintf(buffer, sizeof(buffer), "%d", n);

18 + snprintf(buffer, sizeof(buffer), "%d", n);

19 return string(buffer);

20 }

21 };

OLD	NEW