third_party/libphonenumber/README.chromium - Issue 8736001: Pull the phone library directly. Delete old version.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libphonenumber/README.chromium

Issue 8736001: Pull the phone library directly. Delete old version. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 Name: International Phone Number Library	1 Name: International Phone Number Library

2 Short Name: libphonenumber	2 Short Name: libphonenumber

3 URL: http://libphonenumber.googlecode.com/svn/trunk/	3 URL: http://libphonenumber.googlecode.com/svn/trunk/

4 Version: unknown	4 Version: unknown

5 Revision: 277	5 Revision: 403

6 Security Critical: yes	6 Security Critical: yes

7	7

8 This directory contains the source code of International Phone Number Library	8 This directory contains the source code of International Phone Number Library

9 for C/C++.	9 for C/C++.

10	10

11 This library depends on	11 This library depends on

12 1. base/ for types, scoped_ptr's, etc.	12 1. base/ for types, scoped_ptr's, etc.

13 2. third_party/icu for internationalisation, UTF8-16-32 conversion and regular	13 2. third_party/icu for internationalisation, UTF8-16-32 conversion and regular

14 expressions.	14 expressions.

15 3. third_party/protobuf Lite version.	15 3. third_party/protobuf Lite version.

16	16

17 Additional files, not in the original library:	17 Additional files, not in the original library:

18 libphonenumber.gyp	18 libphonenumber.gyp

19 README.chromium	19 README.chromium

20	20

21 Until the changes are upstreamed library is included directly, with patches	21 The library is mapped through the DEPS file into src/ folder. To update:

22 in patches/version277.patch and patches/version277a.patch applied.	22 1. Get the latest version number from

23	23 http://code.google.com/p/libphonenumber/source/list

24 The folders included in our repository for now are	24 2. Locally update this file and DEPS.

25 cpp/	25 3. run 'gclient sync'

26 resource/	26 4. Adjust libphonenumber.gyp if necessary.

27	27 5. Verify that all compiles and all of the tests are successfull.

28 TODO(georgey) : remove following lines when updated to version after 186

29 cpp/src/phonelibutil.cc made icu::Transliteration member of PhoneUtil

30 to improve performance, Not needed in recent versions.

31

OLD	NEW

« chrome/browser/autofill/phone_number_i18n.cc ('K') | « chrome/browser/autofill/phone_number_i18n.cc ('k') | third_party/libphonenumber/cpp/CMakeLists.txt » ('j') | no next file with comments »