Add App Notification Sync Integration Test

chrome/browser/sync/test/integration/app_notification_helper.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_APP_NOTIFICATION_HELPER_H_
+#define CHROME_BROWSER_SYNC_TEST_INTEGRATION_APP_NOTIFICATION_HELPER_H_
+#pragma once
+
+#include <map>
+#include <string>
+
+#include "base/string16.h"
+
+class AppNotification;
+class AppNotificationManager;
+
+typedef std::map<std::string, const AppNotification*> GUIDToTURLMap;

[asargent_no_longer_on_chrome, 2011/12/03 05:34:30]

nit: What's a TURL? =)

Should this be named "GUIDToNotificationMap" or something like that? 

+
+namespace app_notification_helper {
+
+// Used to access the search engines within a particular sync profile.

[Munjal (Google), 2011/12/03 05:03:49]

Remove reference to "search engine" in comments. Here and other places in this
file.

+AppNotificationManager* GetServiceForProfile(int index);

[Raghu Simha, 2011/12/05 18:33:56]

Rename to GetAppNotificationManager().

+
+// Used to access the search engines within the verifier sync profile.
+AppNotificationManager* GetVerifierService();

[Raghu Simha, 2011/12/05 18:33:56]

GetVerifierAppNotificationManager().

+
+// Compared a single AppNotificationManager for a given profile to the verifier.

[Munjal (Google), 2011/12/03 05:03:49]

Nit: Compares

+// Retrns true iff their user-visible fields match.

[Munjal (Google), 2011/12/03 05:03:49]

Nit: Returns

+bool ServiceMatchesVerifier(int profile, const std::string& extension_id);
+
+// Returns true iff the major user-visible fields of |not1| and |not2| match.
+bool AppNotificationMatch(const AppNotification* not1,

[Raghu Simha, 2011/12/05 18:33:56]

nit: Rename to AppNotificationsMatch().

+                          const AppNotification* not2);
+
+// Add a notification based on the seed at index |profile| and the
+// verifier if it is used.
+void AddNotification(int profile, int seed);

[Raghu Simha, 2011/12/05 18:33:56]

nit: Rename to AddAppNotification().

+
+// Create an AppNotification with some test values based on |seed|.
+// The caller owns the returned AppNotification*.

[Munjal (Google), 2011/12/03 05:03:49]

Nit: AppNotification* -> AppNotification.

+AppNotification* CreateTestAppNotification(int seed);

[Raghu Simha, 2011/12/05 18:33:56]

Nit: Add a blank line here.

+}  // namespace app_notification_helper
+
+#endif  // CHROME_BROWSER_SYNC_TEST_INTEGRATION_APP_NOTIFICATION_HELPER_H_
+

[Raghu Simha, 2011/12/05 18:33:56]

nit: Delete extra blank line.