Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: git_cl.py

Issue 8735018: Make --send-mail more useful by not requiring -r (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index aff809ed9bdcb4623b2e54167757802ce16132a8..c0d9c9403e38d9b2f4dd3f937df87e5f456b41b5 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -920,10 +920,6 @@ def CMDupload(parser, args):
upload_args.extend(['--server', cl.GetRietveldServer()])
if options.emulate_svn_auto_props:
upload_args.append('--emulate_svn_auto_props')
- if options.send_mail:
- if not options.reviewers:
- DieWithError("Must specify reviewers to send email.")
- upload_args.append('--send_mail')
if options.from_logs and not options.message:
print 'Must set message for subject line if using desc_from_logs'
return 1
@@ -951,6 +947,10 @@ def CMDupload(parser, args):
upload_args.extend(['--description', change_desc.description])
if change_desc.reviewers:
upload_args.extend(['--reviewers', change_desc.reviewers])
+ if options.send_mail:
+ if not change_desc.reviewers:
+ DieWithError("Must specify reviewers to send email.")
+ upload_args.append('--send_mail')
cc = ','.join(filter(None, (cl.GetCCList(), options.cc)))
if cc:
upload_args.extend(['--cc', cc])
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698