content/ppapi_plugin/ppapi_thread.cc - Issue 8735015: Add CHECK on file descriptor in various IPC::ChannelHandle passed in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/ppapi_plugin/ppapi_thread.cc

Issue 8735015: Add CHECK on file descriptor in various IPC::ChannelHandle passed in. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Remove CHECK in plugin thread. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/ppapi_plugin/ppapi_thread.cc

diff --git a/content/ppapi_plugin/ppapi_thread.cc b/content/ppapi_plugin/ppapi_thread.cc

index c5f2a6bbc5e6b021ddcc33ef4299cec92f417d0b..0d16f9a464e711a13f6f190dda6a04db0b6ce9d9 100644

--- a/content/ppapi_plugin/ppapi_thread.cc

+++ b/content/ppapi_plugin/ppapi_thread.cc

@@ -303,6 +303,9 @@ bool PpapiThread::SetupRendererChannel(base::ProcessHandle host_process_handle,

// This ensures this process will be notified when it is closed even if a

// connection is not established.

handle->socket = base::FileDescriptor(dispatcher->TakeRendererFD(), true);

+ // Check the validity of fd for bug investigation. Remove after fixed.

+ // See for details: crbug.com/103957.

+ CHECK_NE(-1, handle->socket.fd);

if (handle->socket.fd == -1)

return false;

#endif

« no previous file with comments | « content/common/np_channel_base.cc ('k') | content/renderer/pepper_plugin_delegate_impl.cc » ('j') | no next file with comments »