content/browser/renderer_host/render_message_filter.cc - Issue 8735015: Add CHECK on file descriptor in various IPC::ChannelHandle passed in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 8735015: Add CHECK on file descriptor in various IPC::ChannelHandle passed in. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Remove CHECK in plugin thread. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_message_filter.cc

diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc

index 7c2f9ba78b297b0333ba0f7fbb2f541fb1486bd9..59ffa8b026dcebc5b0c5d9ae1c2c39049a3d19f4 100644

--- a/content/browser/renderer_host/render_message_filter.cc

+++ b/content/browser/renderer_host/render_message_filter.cc

@@ -159,6 +159,11 @@ class OpenChannelToPpapiBrokerCallback

virtual void OnChannelOpened(base::ProcessHandle broker_process_handle,

const IPC::ChannelHandle& channel_handle) {

+#if defined(OS_POSIX)

+ // Check the validity of fd for bug investigation. Remove after fixed.

+ // See for details: crbug.com/103957.

+ CHECK_NE(-1, channel_handle.socket.fd);

+#endif

filter_->Send(new ViewMsg_PpapiBrokerChannelCreated(routing_id_,

request_id_,

broker_process_handle,

« no previous file with comments | « no previous file | content/common/gpu/gpu_channel_manager.cc » ('j') | no next file with comments »