Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 8735013: Pepper IDL: also generate files from 'private' (Closed)

Created:
9 years ago by piman
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper IDL: also generate files from 'private' BUG=none TEST=./generator.py --wnone --cgen --range=start,end --out private/ppb_flash_fullscreen.idl Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ppapi/generators/idl_parser.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
piman
9 years ago (2011-11-30 01:17:16 UTC) #1
noelallen_use_chromium
LGTM
9 years ago (2011-11-30 02:12:56 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-11-30 02:29:49 UTC) #3
piman
On Tue, Nov 29, 2011 at 6:29 PM, <commit-bot@chromium.org> wrote: > No LGTM from valid ...
9 years ago (2011-11-30 03:47:25 UTC) #4
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-11-30 06:52:47 UTC) #5
noelallen1
lgtm
9 years ago (2011-11-30 06:52:59 UTC) #6
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-11-30 06:53:27 UTC) #7
dmichael (off chromium)
lgtm
9 years ago (2011-11-30 15:38:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8735013/1
9 years ago (2011-11-30 15:38:46 UTC) #9
commit-bot: I haz the power
9 years ago (2011-11-30 16:52:43 UTC) #10
Change committed as 112239

Powered by Google App Engine
This is Rietveld 408576698