Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 8735007: Unswap sync backend initialize histograms (Closed)

Created:
9 years ago by rlarocque
Modified:
9 years ago
Reviewers:
Nicolas Zea, lipalani1
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

Unswap sync backend initialize histograms This commit also renames the histograms so we can obsolete the old names and ignore all the stats gathered while the labels were swapped. BUG=105777 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rlarocque
Remember http://codereview.chromium.org/8568028? It turns out that I accidentally swapped the histogram labels. This commit fixes ...
9 years ago (2011-11-29 22:29:14 UTC) #1
lipalani1
LGTM
9 years ago (2011-11-30 00:42:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/8735007/1
9 years ago (2011-11-30 00:44:26 UTC) #3
commit-bot: I haz the power
9 years ago (2011-11-30 02:56:31 UTC) #4
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_clang, revision is 112082, job name
was 8735007-1 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).

Powered by Google App Engine
This is Rietveld 408576698