Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 8735005: Exclude ClientSocketPoolBaseTest.DisableCleanupTimer under DrMemory (Closed)

Created:
9 years ago by Reid Kleckner
Modified:
9 years ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Exclude ClientSocketPoolBaseTest.DisableCleanupTimer under DrMemory This is a hang that slows down the bot and the test looks very sensitive to timing. I'm not interested in fully investigating this failure, and I'd like the bot to cycle faster sooner. R=bruening@chromium.org BUG=105762 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Reid Kleckner
PTAL
9 years ago (2011-11-29 21:39:04 UTC) #1
Derek Bruening
LGTM
9 years ago (2011-11-29 22:16:03 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-11-29 22:31:33 UTC) #3
Timur Iskhodzhanov
lgtm
9 years ago (2011-11-30 09:24:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/8735005/1
9 years ago (2011-11-30 09:24:17 UTC) #5
commit-bot: I haz the power
9 years ago (2011-11-30 11:38:22 UTC) #6
Change committed as 112198

Powered by Google App Engine
This is Rietveld 408576698