Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 8735003: Fix the components build on Linux. (Closed)

Created:
9 years ago by tony
Modified:
9 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Fix the components build on Linux. We were including the wrong GLES2/gl2.h file. This was previously fixed in http://codereview.chromium.org/8540032 , but we regressed it http://codereview.chromium.org/8423038/ . It looks like we were getting the copy in third_party/angle/include. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/gpu/transport_texture_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tony
9 years ago (2011-11-29 21:27:39 UTC) #1
Dirk Pranke
On 2011/11/29 21:27:39, tony wrote: lgtm.
9 years ago (2011-11-29 21:37:59 UTC) #2
tony
(+another owner)
9 years ago (2011-11-29 22:17:16 UTC) #3
Ken Russell (switch to Gerrit)
lgtm
9 years ago (2011-11-29 23:36:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/8735003/1
9 years ago (2011-11-29 23:38:09 UTC) #5
commit-bot: I haz the power
Try job failure for 8735003-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-11-30 00:23:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/8735003/1
9 years ago (2011-11-30 00:26:04 UTC) #7
commit-bot: I haz the power
Try job failure for 8735003-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-11-30 01:26:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/8735003/1
9 years ago (2011-11-30 18:04:43 UTC) #9
commit-bot: I haz the power
9 years ago (2011-11-30 19:37:57 UTC) #10
Change committed as 112266

Powered by Google App Engine
This is Rietveld 408576698