Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/extensions/extension_host.h

Issue 8734018: Fix regression with extension popup bubbles on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_host.h
diff --git a/chrome/browser/extensions/extension_host.h b/chrome/browser/extensions/extension_host.h
index 89ad53be4e90ba031104852ae84c33f4c32d2128..bbb8d7e7d661b7c8d2554f8d7773351f0d8c0878 100644
--- a/chrome/browser/extensions/extension_host.h
+++ b/chrome/browser/extensions/extension_host.h
@@ -109,6 +109,7 @@ class ExtensionHost : public TabContentsDelegate,
// TabContentsObserver
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE;
+ virtual void RenderViewDeleted(RenderViewHost* render_view_host) OVERRIDE;
virtual void RenderViewReady() OVERRIDE;
virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE;
virtual void DocumentAvailableInMainFrame() OVERRIDE;
@@ -188,6 +189,11 @@ class ExtensionHost : public TabContentsDelegate,
// The host for our HTML content.
scoped_ptr<TabContents> host_contents_;
+ // A weak pointer to the current or pending RenderViewHost. We don't access
+ // this through the host_contents because we want to deal with the pending
+ // host, so we can send messages to it before it finishes loading.
+ RenderViewHost* render_view_host_;
+
// Whether the RenderWidget has reported that it has stopped loading.
bool did_stop_loading_;
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698