Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 8734018: Fix regression with extension popup bubbles on Mac. (Closed)

Created:
9 years ago by Matt Perry
Modified:
9 years ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Erik does not do reviews, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix regression with extension popup bubbles on Mac. BUG=105446 TEST=popups look normal Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112621

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : comments #

Patch Set 4 : nullcheck rph #

Patch Set 5 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M chrome/browser/extensions/extension_host.h View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 3 4 6 chunks +16 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_view_mac.mm View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Matt Perry
9 years ago (2011-11-30 22:28:44 UTC) #1
Aaron Boodman
LGTM
9 years ago (2011-12-01 02:40:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/8734018/9001
9 years ago (2011-12-02 00:08:08 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-02 02:42:51 UTC) #4
Change committed as 112621

Powered by Google App Engine
This is Rietveld 408576698