Issue 8734017: base::Bind: More random cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8734017: base::Bind: More random cleanups. (Closed)

Created:
9 years ago by James Hawkins

Modified:
9 years ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind: More random cleanups. BUG=none TEST=none R=groby@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112362

Patch Set 1 #

Patch Set 2 : Mac build fix. #

Patch Set 3 : Mac build fix 2. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -85 lines)			Patch
M	content/browser/geolocation/gps_location_provider_unittest_linux.cc	View		2 chunks	+5 lines, -8 lines	0 comments	Download
M	content/browser/mach_broker_mac.h	View	1	2 chunks	+6 lines, -5 lines	0 comments	Download
M	content/browser/mach_broker_mac.cc	View	1 2	5 chunks	+20 lines, -33 lines	0 comments	Download
M	net/base/keygen_handler_unittest.cc	View		3 chunks	+23 lines, -35 lines	0 comments	Download
M	net/curvecp/client_packetizer.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	net/curvecp/client_packetizer.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

I made some big changes to fix the mac build. Please take another look.

9 years ago (2011-11-30 03:13:54 UTC) #3

groby-ooo-7-16

9 years ago (2011-11-30 21:10:27 UTC) #4

On 2011/11/30 03:13:54, James Hawkins wrote:
> I made some big changes to fix the mac build. Please take another look.

lgtm - didn't see _big_ changes, though. So let me know if I miss something

Expand Messages | Collapse Messages