chrome/common/extensions/extension_constants.cc - Issue 8734016: Make platform apps use and require a different container ("shell" instead of "panel")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_constants.cc

Issue 8734016: Make platform apps use and require a different container ("shell" instead of "panel") (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix socket test Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.h ('K') | « chrome/common/extensions/extension_constants.h ('k') | chrome/common/extensions/extension_manifests_unittest.cc » ('j') | chrome/test/data/extensions/platform_app/manifest.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_constants.cc

diff --git a/chrome/common/extensions/extension_constants.cc b/chrome/common/extensions/extension_constants.cc

index 477a0e33c3e57e8d2d82875d7aa08214cf524007..2d0e73004b62634c61d79a951393c4101e298dbd 100644

--- a/chrome/common/extensions/extension_constants.cc

+++ b/chrome/common/extensions/extension_constants.cc

@@ -127,6 +127,7 @@ const char kRunAtDocumentIdle[] = "document_idle";

const char kPageActionTypeTab[] = "tab";

const char kPageActionTypePermanent[] = "permanent";

const char kLaunchContainerPanel[] = "panel";

+const char kLaunchContainerShell[] = "shell";

const char kLaunchContainerTab[] = "tab";

const char kLaunchContainerWindow[] = "window";

} // namespace extension_manifest_values

@@ -256,8 +257,10 @@ const char kInvalidKey[] =

"Value 'key' is missing or invalid.";

const char kInvalidLaunchContainer[] =

"Invalid value for 'app.launch.container'.";

+const char kInvalidLaunchContainerForNonPlatform[] =

+ "'app.launch.container' = 'shell' can only be used with platform_app.";

const char kInvalidLaunchContainerForPlatform[] =

- "platform_app requires 'app.launch.container' == 'panel'.";

+ "platform_app requires 'app.launch.container' == 'shell'.";

const char kInvalidLaunchHeight[] =

"Invalid value for 'app.launch.height'.";

const char kInvalidLaunchHeightContainer[] =