Always generate host secrets of correct length.

Always generate host secrets of correct length.

BUG=105798
TEST=Access code is always 12 digits long.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112137

[Wez, 2011-11-30 00:34:25]

http://codereview.chromium.org/8734012/diff/1/remoting/host/host_secret.cc
File remoting/host/host_secret.cc (right):

http://codereview.chromium.org/8734012/diff/1/remoting/host/host_secret.cc#ne...
remoting/host/host_secret.cc:23: const int kMaxHostSecret = 100000;  // Must be
equal 10^kHostSecretLength.
Can this be 10^kHostSecretLength, or will that end up being calculated at
run-time?

http://codereview.chromium.org/8734012/diff/1/remoting/host/host_secret.cc#ne...
remoting/host/host_secret.cc:38: return out.str();
Ick.  Beginning to think the byte-by-byte version was simpler...  Is this really
the simplest way to do this in C++?

[Sergey Ulanov, 2011-11-30 01:12:26]

http://codereview.chromium.org/8734012/diff/1/remoting/host/host_secret.cc
File remoting/host/host_secret.cc (right):

http://codereview.chromium.org/8734012/diff/1/remoting/host/host_secret.cc#ne...
remoting/host/host_secret.cc:23: const int kMaxHostSecret = 100000;  // Must be
equal 10^kHostSecretLength.
On 2011/11/30 00:34:26, Wez wrote:
> Can this be 10^kHostSecretLength, or will that end up being calculated at
> run-time?

Done.

http://codereview.chromium.org/8734012/diff/1/remoting/host/host_secret.cc#ne...
remoting/host/host_secret.cc:38: return out.str();
On 2011/11/30 00:34:26, Wez wrote:
> Ick.  Beginning to think the byte-by-byte version was simpler...  Is this
really
> the simplest way to do this in C++?
Yes. Some other code in chromium uses the same approach, e.g. logging. Two other
ways to do it I can think of:
 1. add zeros with while loop,
 2. use sprintf,
None of these would be prettier than the current version.

[Sergey Ulanov, 2011-11-30 01:26:54]

I've reverted this code back to the initial version of the host secret
generator.

[Wez, 2011-11-30 01:32:02]

lgtm

[commit-bot: I haz the power, 2011-11-30 01:32:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/8734012/1003

[commit-bot: I haz the power, 2011-11-30 02:45:00]

Try job failure for 8734012-1003 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-11-30 02:53:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/8734012/9002

[commit-bot: I haz the power, 2011-11-30 06:16:27]

Change committed as 112137