Revive reverted path.

Revive reverted path.
Original patch: http://src.chromium.org/viewvc/chrome?view=rev&revision=111882
Reverted in: http://src.chromium.org/viewvc/chrome?view=rev&revision=111944

Apart from the exact same files as the original patch, this contains a change
to sync integration tests that fixes those tests. The change is to set a fake
response for OAuth2 login token fetch request.

I ran sync_integration_tests locally and they all pass now.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112165

[Raghu Simha, 2011-11-29 23:50:52]

Additional change to sync_test.cc LGTM. Thanks for taking care of this.

[Raghu Simha, 2011-11-29 23:56:59]

Still LGTM, pending one nit.

http://codereview.chromium.org/8734009/diff/1/chrome/browser/sync/test/integr...
File chrome/browser/sync/test/integration/sync_test.cc (right):

http://codereview.chromium.org/8734009/diff/1/chrome/browser/sync/test/integr...
chrome/browser/sync/test/integration/sync_test.cc:71: static const char
kOAuth2LoginTokenValidResponse[] =
nit: Remove static modifier.

[Munjal (Google), 2011-11-30 00:02:00]

http://codereview.chromium.org/8734009/diff/1/chrome/browser/sync/test/integr...
File chrome/browser/sync/test/integration/sync_test.cc (right):

http://codereview.chromium.org/8734009/diff/1/chrome/browser/sync/test/integr...
chrome/browser/sync/test/integration/sync_test.cc:71: static const char
kOAuth2LoginTokenValidResponse[] =
On 2011/11/29 23:56:59, rsimha wrote:
> nit: Remove static modifier.

Done.

[lipalani1, 2011-11-30 00:04:27]

LGTMing the original patch. This is just a rubberstamp approval since Rick is
out. Rick has LGTMed the original patch.

[tim (not reviewing), 2011-11-30 08:17:57]

lgtm

[Rick Campbell, 2011-11-30 19:06:46]

lgtm