Issue 8734006: Get more information about types of images being downloaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8734006: Get more information about types of images being downloaded. (Closed)

Created:
9 years ago by cbentzel

Modified:
9 years ago

Reviewers:
ahendrickson

CC:
chromium-reviews, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., James Hawkins

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get more information about types of images being downloaded. This adds a new enum Download.ContentImageType rather than adding additional entries to Download.ContentType. The downside is that there is a bit more code. The upside is that we don't have to worry about the image entries getting fragmented across the Download.ContentType enum, and there is a top-level entry for images in the Download.ContentType histogram to compare against other general media types. TEST=Download a few images, make sure Download.ContentType and Download.ContentImageType look sane. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112711

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -2 lines)			Patch
	M	content/browser/download/download_stats.cc	View		3 chunks	+44 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/8734006/1

9 years ago (2011-12-02 14:53:03 UTC) #3

Change committed as 112711

Expand Messages | Collapse Messages