Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 8734004: Remove parsing of %(branch) as it is not reliable from the buildbot waterfall. (Closed)

Created:
9 years ago by sosa
Modified:
9 years ago
Reviewers:
Peter Mayo, scottz
CC:
chromium-reviews, cmp, Nicolas Sylvain
Visibility:
Public.

Description

Remove parsing of %(branch) as it is not reliable from the buildbot waterfall. BUG=TreeCloser TEST=make restart on chromiumos master. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M scripts/master/factory/chromeos_factory.py View 2 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sosa
9 years ago (2011-11-29 22:14:02 UTC) #1
sosa
ptal
9 years ago (2011-11-29 22:14:13 UTC) #2
sosa
9 years ago (2011-11-30 02:15:36 UTC) #3
scottz
On 2011/11/29 22:14:13, sosa wrote: > ptal LGTM
9 years ago (2011-11-30 02:16:48 UTC) #4
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-11-30 02:17:05 UTC) #5
sosa
LGTM
9 years ago (2011-11-30 02:48:54 UTC) #6
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-11-30 02:49:12 UTC) #7
scottz
On 2011/11/30 02:49:12, I haz the power (commit-bot) wrote: > No LGTM from valid reviewers ...
9 years ago (2011-11-30 02:52:25 UTC) #8
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-11-30 02:52:42 UTC) #9
Peter Mayo
9 years ago (2011-11-30 22:39:24 UTC) #10
lgtm

Powered by Google App Engine
This is Rietveld 408576698