Issue 8734: Fix 3 places where we were doing retry after GC without using the macros that...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8734: Fix 3 places where we were doing retry after GC without using the macros that... (Closed)

Created:
12 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix 3 places where we were doing retry after GC without using the macros that were defined for that purpose. Committed: http://code.google.com/p/v8/source/detail?r=650

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -79 lines)			Patch
M	src/builtins.cc	View	1 chunk	+6 lines, -7 lines	0 comments	Download
M	src/factory.cc	View	2 chunks	+12 lines, -27 lines	0 comments	Download
M	src/jsregexp.cc	View	2 chunks	+67 lines, -45 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

12 years, 1 month ago (2008-10-30 11:10:11 UTC) #2

LGTM.  It actually seems like a nice cleanup anyway.

http://codereview.chromium.org/8734/diff/1/3
File src/jsregexp.cc (right):

http://codereview.chromium.org/8734/diff/1/3#newcode321
Line 321: *code = NULL;
Do you need this?

Expand Messages | Collapse Messages