Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8733013: base::Bind fixes (Closed)

Created:
9 years ago by groby-ooo-7-16
Modified:
9 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed review issues #

Total comments: 2

Patch Set 3 : Fixed review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M content/plugin/webplugin_delegate_stub.cc View 1 2 3 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
groby-ooo-7-16
9 years ago (2011-11-30 01:07:33 UTC) #1
James Hawkins
http://codereview.chromium.org/8733013/diff/1/content/plugin/webplugin_delegate_stub.cc File content/plugin/webplugin_delegate_stub.cc (right): http://codereview.chromium.org/8733013/diff/1/content/plugin/webplugin_delegate_stub.cc#newcode61 content/plugin/webplugin_delegate_stub.cc:61: base::Bind(FinishDestructionCallback, delegate_,webplugin_)); &Finish
9 years ago (2011-11-30 01:09:09 UTC) #2
groby-ooo-7-16
9 years ago (2011-11-30 02:19:14 UTC) #3
James Hawkins
LGTM with nit. http://codereview.chromium.org/8733013/diff/5001/content/plugin/webplugin_delegate_stub.cc File content/plugin/webplugin_delegate_stub.cc (right): http://codereview.chromium.org/8733013/diff/5001/content/plugin/webplugin_delegate_stub.cc#newcode61 content/plugin/webplugin_delegate_stub.cc:61: base::Bind(&FinishDestructionCallback, delegate_,webplugin_)); nit: Space after comma.
9 years ago (2011-11-30 02:22:50 UTC) #4
groby-ooo-7-16
http://codereview.chromium.org/8733013/diff/5001/content/plugin/webplugin_delegate_stub.cc File content/plugin/webplugin_delegate_stub.cc (right): http://codereview.chromium.org/8733013/diff/5001/content/plugin/webplugin_delegate_stub.cc#newcode61 content/plugin/webplugin_delegate_stub.cc:61: base::Bind(&FinishDestructionCallback, delegate_,webplugin_)); On 2011/11/30 02:22:50, James Hawkins wrote: > ...
9 years ago (2011-11-30 02:28:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/8733013/5001
9 years ago (2011-11-30 02:29:23 UTC) #6
commit-bot: I haz the power
Presubmit check for 8733013-5001 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-11-30 02:29:25 UTC) #7
groby-ooo-7-16
9 years ago (2011-11-30 02:31:46 UTC) #8
groby-ooo-7-16
+darin, +stuartmorgan: Can one of you provide OWNERS check?
9 years ago (2011-12-02 00:05:06 UTC) #9
stuartmorgan
LGTM
9 years ago (2011-12-02 10:48:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/8733013/5002
9 years ago (2011-12-02 20:02:31 UTC) #11
commit-bot: I haz the power
9 years ago (2011-12-02 21:42:11 UTC) #12 
Change committed as 112793

Powered by Google App Engine
This is Rietveld 408576698