Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 8733004: Make ExtensionService use ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: = Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index e68deb35f7e1e0b24c03cbf83de44461e47fcd02..093534f96de2f94ed98c4abe1cd5c9ab03577ff3 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -41,6 +41,7 @@
#include "chrome/browser/sync/api/syncable_service.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_constants.h"
+#include "chrome/common/extensions/extension_set.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -86,7 +87,7 @@ class ExtensionServiceInterface : public SyncableService {
typedef bool (*ExtensionFilter)(const Extension&);
virtual ~ExtensionServiceInterface() {}
- virtual const ExtensionList* extensions() const = 0;
+ virtual const ExtensionSet* extensions() const = 0;
virtual PendingExtensionManager* pending_extension_manager() = 0;
// Install an update. Return true if the install can be started.
@@ -192,9 +193,9 @@ class ExtensionService
virtual ~ExtensionService();
// Gets the list of currently installed extensions.
- virtual const ExtensionList* extensions() const OVERRIDE;
- const ExtensionList* disabled_extensions() const;
- const ExtensionList* terminated_extensions() const;
+ virtual const ExtensionSet* extensions() const OVERRIDE;
+ const ExtensionSet* disabled_extensions() const;
+ const ExtensionSet* terminated_extensions() const;
// Gets the object managing the set of pending extensions.
virtual PendingExtensionManager* pending_extension_manager() OVERRIDE;
@@ -622,7 +623,7 @@ class ExtensionService
// Appends sync data objects for every extension in |extensions|
// that passes |filter|.
void GetSyncDataListHelper(
- const ExtensionList& extensions,
+ const ExtensionSet& extensions,
const SyncBundle& bundle,
std::vector<ExtensionSyncData>* sync_data_list) const;
@@ -682,16 +683,13 @@ class ExtensionService
// The current list of installed extensions.
// TODO(aa): This should use chrome/common/extensions/extension_set.h.
- ExtensionList extensions_;
+ ExtensionSet extensions_;
// The list of installed extensions that have been disabled.
- ExtensionList disabled_extensions_;
+ ExtensionSet disabled_extensions_;
// The list of installed extensions that have been terminated.
- ExtensionList terminated_extensions_;
-
- // Used to quickly check if an extension was terminated.
- std::set<std::string> terminated_extension_ids_;
+ ExtensionSet terminated_extensions_;
// Hold the set of pending extensions.
PendingExtensionManager pending_extension_manager_;

Powered by Google App Engine
This is Rietveld 408576698