Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.cc

Issue 8733004: Make ExtensionService use ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: + Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/app_launcher_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
index d0b075db106d60b779bef20b5b5e4abacb3bfc34..dfabdcb057659e2c4731697a627a784901f79dd4 100644
--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
@@ -327,11 +327,12 @@ void AppLauncherHandler::FillAppDictionary(DictionaryValue* dictionary) {
AutoReset<bool> auto_reset(&ignore_changes_, true);
ListValue* list = new ListValue();
- const ExtensionList* extensions = extension_service_->extensions();
- ExtensionList::const_iterator it;
+ const ExtensionSet* extensions = extension_service_->extensions();
+ ExtensionSet::const_iterator it;
for (it = extensions->begin(); it != extensions->end(); ++it) {
- if (!IsAppExcludedFromList(*it)) {
- DictionaryValue* app_info = GetAppInfo(*it);
+ const Extension* extension = *it;
+ if (!IsAppExcludedFromList(extension)) {
+ DictionaryValue* app_info = GetAppInfo(extension);
list->Append(app_info);
} else {
// This is necessary because in some previous versions of chrome, we set a
@@ -339,8 +340,8 @@ void AppLauncherHandler::FillAppDictionary(DictionaryValue* dictionary) {
// and this fixes it. If we don't fix it, GetNaturalAppPageIndex() doesn't
// work. See http://crbug.com/98325
ExtensionPrefs* prefs = extension_service_->extension_prefs();
- if (prefs->GetPageIndex((*it)->id()) != -1)
- prefs->ClearPageIndex((*it)->id());
+ if (prefs->GetPageIndex(extension->id()) != -1)
+ prefs->ClearPageIndex(extension->id());
}
}

Powered by Google App Engine
This is Rietveld 408576698