Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: chrome/browser/extensions/network_delay_listener_unittest.cc

Issue 8733004: Make ExtensionService use ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: + Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/installed_loader.cc ('k') | chrome/browser/extensions/test_extension_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/network_delay_listener_unittest.cc
diff --git a/chrome/browser/extensions/network_delay_listener_unittest.cc b/chrome/browser/extensions/network_delay_listener_unittest.cc
index 4e48472e0677e2d943dde03187a0c98877887285..e9d8f585182621c43aa60add4ab8c90c60cc6fb8 100644
--- a/chrome/browser/extensions/network_delay_listener_unittest.cc
+++ b/chrome/browser/extensions/network_delay_listener_unittest.cc
@@ -127,9 +127,9 @@ class NetworkDelayListenerTest
void LoadTestExtension1() {
LoadTestExtension(kTestExtensionId1);
- ASSERT_FALSE(service_->extensions()->empty());
- extension1_ = service_->extensions()->at(0).get();
- ASSERT_FALSE(extension1_ == NULL);
+ ASSERT_FALSE(service_->extensions()->is_empty());
+ extension1_ = service_->extensions()->GetByID(kTestExtensionId1);
+ ASSERT_TRUE(extension1_);
}
void SendExtensionLoadedNotification(const Extension* extension) {
@@ -197,8 +197,9 @@ TEST_F(NetworkDelayListenerTest, TwoBlockingExtensions) {
LoadTestExtension1();
LoadTestExtension(kTestExtensionId2);
ASSERT_EQ(2u, service_->extensions()->size());
- const Extension* extension2 = service_->extensions()->at(1).get();
- ASSERT_FALSE(extension2 == NULL);
+ const Extension* extension2 =
+ service_->extensions()->GetByID(kTestExtensionId2);
+ ASSERT_TRUE(extension2);
TestDelegate delegate;
scoped_ptr<TestURLRequest> request(StartTestRequest(&delegate, kTestUrl));
@@ -231,7 +232,7 @@ TEST_F(NetworkDelayListenerTest, ExtensionReadyTwice) {
// Tests that there's no delay if no loaded extension needs one.
TEST_F(NetworkDelayListenerTest, NoDelayNoWebRequest) {
LoadTestExtension(kTestExtensionNoNetworkDelay);
- ASSERT_FALSE(service_->extensions()->empty());
+ ASSERT_FALSE(service_->extensions()->is_empty());
TestDelegate delegate;
scoped_ptr<TestURLRequest> request(StartTestRequest(&delegate, kTestUrl));
« no previous file with comments | « chrome/browser/extensions/installed_loader.cc ('k') | chrome/browser/extensions/test_extension_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698