Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Unified Diff: chrome/browser/extensions/extension_updater_unittest.cc

Issue 8733004: Make ExtensionService use ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: + Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_updater_unittest.cc
diff --git a/chrome/browser/extensions/extension_updater_unittest.cc b/chrome/browser/extensions/extension_updater_unittest.cc
index e8f3c526c7355cb91cd82b77278c643a962f04ed..e475feb37144fc0e38cc4505a2fdf3dc9e04c202 100644
--- a/chrome/browser/extensions/extension_updater_unittest.cc
+++ b/chrome/browser/extensions/extension_updater_unittest.cc
@@ -153,16 +153,10 @@ class ServiceForManifestTests : public MockService {
virtual const Extension* GetExtensionById(
const std::string& id, bool include_disabled) const OVERRIDE {
- for (ExtensionList::const_iterator iter = extensions_.begin();
- iter != extensions_.end(); ++iter) {
- if ((*iter)->id() == id) {
- return *iter;
- }
- }
- return NULL;
+ return extensions_.GetByID(id);
}
- virtual const ExtensionList* extensions() const OVERRIDE {
+ virtual const ExtensionSet* extensions() const OVERRIDE {
return &extensions_;
}
@@ -171,11 +165,14 @@ class ServiceForManifestTests : public MockService {
}
void set_extensions(ExtensionList extensions) {
- extensions_ = extensions;
+ for (ExtensionList::const_iterator it = extensions.begin();
+ it != extensions.end(); ++it) {
+ extensions_.Insert(*it);
+ }
}
private:
- ExtensionList extensions_;
+ ExtensionSet extensions_;
};
class ServiceForDownloadTests : public MockService {
« no previous file with comments | « chrome/browser/extensions/extension_updater.cc ('k') | chrome/browser/extensions/extension_webrequest_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698