chrome/browser/background/background_application_list_model_unittest.cc - Issue 8733004: Make ExtensionService use ExtensionSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_application_list_model_unittest.cc

Issue 8733004: Make ExtensionService use ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: + Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_application_list_model.cc ('k') | chrome/browser/background/background_contents_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background/background_application_list_model_unittest.cc

diff --git a/chrome/browser/background/background_application_list_model_unittest.cc b/chrome/browser/background/background_application_list_model_unittest.cc

index f3fff07e121f13098aaba0be62edf88fe7f9a219..4024fad6dfd1b2d4d767d00eaf494c7ee24ca983 100644

--- a/chrome/browser/background/background_application_list_model_unittest.cc

+++ b/chrome/browser/background/background_application_list_model_unittest.cc

@@ -60,8 +60,11 @@ static scoped_refptr<Extension> CreateExtension(const std::string& name,

}

std::string error;

scoped_refptr<Extension> extension = Extension::Create(

- bogus_file_path().AppendASCII(name), Extension::INVALID, manifest,

- Extension::STRICT_ERROR_CHECKS, &error);

+ bogus_file_path().AppendASCII(name),

+ Extension::INVALID,

+ manifest,

+ Extension::STRICT_ERROR_CHECKS,

+ &error);

// Cannot ASSERT_* here because that attempts an illegitimate return.

// Cannot EXPECT_NE here because that assumes non-pointers unlike EXPECT_EQ

EXPECT_TRUE(extension.get() != NULL) << error;

@@ -105,7 +108,7 @@ TEST_F(BackgroundApplicationListModelTest, ExplicitTest) {

ASSERT_TRUE(service);

ASSERT_TRUE(service->is_ready());

ASSERT_TRUE(service->extensions());

- ASSERT_TRUE(service->extensions()->empty());

+ ASSERT_TRUE(service->extensions()->is_empty());

scoped_ptr<BackgroundApplicationListModel> model(

new BackgroundApplicationListModel(profile_.get()));

ASSERT_EQ(0U, model->size());

@@ -171,7 +174,7 @@ TEST_F(BackgroundApplicationListModelTest, AddRemovePermissionsTest) {

ASSERT_TRUE(service);

ASSERT_TRUE(service->is_ready());

ASSERT_TRUE(service->extensions());

- ASSERT_TRUE(service->extensions()->empty());

+ ASSERT_TRUE(service->extensions()->is_empty());

scoped_ptr<BackgroundApplicationListModel> model(

new BackgroundApplicationListModel(profile_.get()));

ASSERT_EQ(0U, model->size());

@@ -310,7 +313,7 @@ TEST_F(BackgroundApplicationListModelTest, RandomTest) {

ASSERT_TRUE(service);

ASSERT_TRUE(service->is_ready());

ASSERT_TRUE(service->extensions());

- ASSERT_TRUE(service->extensions()->empty());

+ ASSERT_TRUE(service->extensions()->is_empty());

scoped_ptr<BackgroundApplicationListModel> model(

new BackgroundApplicationListModel(profile_.get()));

ASSERT_EQ(0U, model->size());