Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5300)

Unified Diff: chrome/installer/util/util_constants.h

Issue 8729009: Implement an AutoLaunch experiment for Chrome for certain brand codes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/master_preferences_constants.cc ('k') | chrome/installer/util/util_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/util_constants.h
===================================================================
--- chrome/installer/util/util_constants.h (revision 114230)
+++ chrome/installer/util/util_constants.h (working copy)
@@ -92,6 +92,9 @@
};
// Stages of an installation reported through Google Update on failure.
+// The order and value of existing enums must not change. Please add new
+// values to the end (before NUM_STAGES) and update the compile assert below
+// to assert on the last value added.
enum InstallerStage {
NO_STAGE, // 0: No stage to report.
PRECONDITIONS, // 1: Evaluating pre-install conditions.
@@ -109,15 +112,17 @@
REGISTERING_CHROME, // 13: Performing Chrome registration.
REMOVING_OLD_VERSIONS, // 14: Deleting old version directories.
FINISHING, // 15: Finishing the install.
- NUM_STAGES // 16: The number of stages.
+ CONFIGURE_AUTO_LAUNCH, // 16: Configuring Chrome to auto-launch.
+ NUM_STAGES // 17: The number of stages.
};
// When we start reporting the numerical values from the enum, the order
// above MUST be preserved.
-COMPILE_ASSERT(FINISHING == 15,
+COMPILE_ASSERT(CONFIGURE_AUTO_LAUNCH == 16,
never_ever_ever_change_InstallerStage_values_bang);
namespace switches {
+extern const char kAutoLaunchChrome[];
extern const char kCeee[];
extern const char kChrome[];
extern const char kChromeFrame[];
« no previous file with comments | « chrome/installer/util/master_preferences_constants.cc ('k') | chrome/installer/util/util_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698