Implement an AutoLaunch experiment for Chrome for certain brand codes.

chrome/installer/util/util_constants.h

Index: chrome/installer/util/util_constants.h
===================================================================
--- chrome/installer/util/util_constants.h	(revision 111708)
+++ chrome/installer/util/util_constants.h	(working copy)
@@ -92,6 +92,9 @@
 };
 
 // Stages of an installation reported through Google Update on failure.
+// The order and value of existing enums must not change. Please add new
+// values to the end (before NUM_STAGES) and update the compile assert to
+// assert on the last value added.
 enum InstallerStage {
   NO_STAGE,                    // 0: No stage to report.
   PRECONDITIONS,               // 1: Evaluating pre-install conditions.
@@ -109,15 +112,17 @@
   REGISTERING_CHROME,          // 13: Performing Chrome registration.
   REMOVING_OLD_VERSIONS,       // 14: Deleting old version directories.
   FINISHING,                   // 15: Finishing the install.
+  CONFIGURE_AUTO_LAUNCH,       // 16: Configuring Chrome to auto-launch.
   NUM_STAGES                   // 16: The number of stages.

[Roger Tawa OOO till Jul 10th, 2011/12/07 15:38:37]

16 --> 17 ?

[grt (UTC plus 2), 2011/12/07 15:56:35]

nice catch

[Finnur, 2011/12/13 15:53:24]

Done.

 };
 
 // When we start reporting the numerical values from the enum, the order
 // above MUST be preserved.
-COMPILE_ASSERT(FINISHING == 15,
+COMPILE_ASSERT(CONFIGURE_AUTO_LAUNCH == 16,
                never_ever_ever_change_InstallerStage_values_bang);

[Roger Tawa OOO till Jul 10th, 2011/12/07 15:38:37]

how does this compile assert help ensure that the enum order above is always
preserved?

[grt (UTC plus 2), 2011/12/07 15:56:35]

it's weak, but it's better than nothing at all.  the assert will fire if someone
fails to read the comment above the enum and inserts a value in the middle.  i
think this is the common case we want to protect against.  the integer values
are included in the comments as an additional hint to editors that they
shouldn't be toyed with.  do you think some additional checks are called for? 
how would you do it?

[Roger Tawa OOO till Jul 10th, 2011/12/07 16:17:16]

OK makes sense Greg.  Yeah, tricky problem to solve without being too onerous on
the developer.

 
 namespace switches {
+extern const char kAutoLaunchChrome[];
 extern const char kCeee[];
 extern const char kChrome[];
 extern const char kChromeFrame[];