Disarm StartupTimeBomb when it is deleted

Delete and disarm StartupTimeBomb when browser is
shutting down if StartupTimeBomb is still Arm'ed.

BUG=105745
R=jar
TEST=browser unit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112372

[ramant (doing other things), 2011-11-30 00:19:58]

Made the following changes to disarm the StartupTimeBomb in case we do early
returns and not call Disarm. We disarm (if it is not disarm'ed) when
StartupTimeBomb is deleted.

- Added scoped_ptr for StartupTimeBomb to disarm during destructor if it wasn't
already disarm'ed. 

- Start the time bomber after the return.

thanks,
raman

[jar (doing other things), 2011-11-30 01:02:01]

http://codereview.chromium.org/8728035/diff/7002/chrome/browser/metrics/threa...
File chrome/browser/metrics/thread_watcher.h (right):

http://codereview.chromium.org/8728035/diff/7002/chrome/browser/metrics/threa...
chrome/browser/metrics/thread_watcher.h:513: friend class ThreadWatcherList;
nit: Why do we need this friend?  Aren't the significant interfaces public?

[ramant (doing other things), 2011-11-30 05:14:52]

http://codereview.chromium.org/8728035/diff/7002/chrome/browser/metrics/threa...
File chrome/browser/metrics/thread_watcher.h (right):

http://codereview.chromium.org/8728035/diff/7002/chrome/browser/metrics/threa...
chrome/browser/metrics/thread_watcher.h:513: friend class ThreadWatcherList;
On 2011/11/30 01:02:01, jar wrote:
> nit: Why do we need this friend?  Aren't the significant interfaces public?

Added a static method to disarm the startup timebomb which will disarm (on UI
thread) if the global object exists.

Done.

[jar (doing other things), 2011-11-30 17:18:39]

http://codereview.chromium.org/8728035/diff/14001/chrome/browser/metrics/thre...
File chrome/browser/metrics/thread_watcher.cc (right):

http://codereview.chromium.org/8728035/diff/14001/chrome/browser/metrics/thre...
chrome/browser/metrics/thread_watcher.cc:852: // This could be disarm'ed during
shutdown when we are not on UI thread.
I think this will be racy if called from other than the UI thread.  What am I
missing? The comment seems confusing, and I'm not sure why we no longer need the
DCHECK.

[ramant (doing other things), 2011-11-30 22:08:40]

Hi Jim,
  Added the check's for thread_id.

thanks,
raman

http://codereview.chromium.org/8728035/diff/14001/chrome/browser/metrics/thre...
File chrome/browser/metrics/thread_watcher.cc (right):

http://codereview.chromium.org/8728035/diff/14001/chrome/browser/metrics/thre...
chrome/browser/metrics/thread_watcher.cc:852: // This could be disarm'ed during
shutdown when we are not on UI thread.
On 2011/11/30 17:18:39, jar wrote:
> I think this will be racy if called from other than the UI thread.  What am I
> missing? The comment seems confusing, and I'm not sure why we no longer need
the
> DCHECK.

Added DCHECK's for thread_id for StartupTimeBomb and ShutdownWatcher.

Done.

[jar (doing other things), 2011-11-30 22:13:52]

lgtm

[commit-bot: I haz the power, 2011-11-30 22:20:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/8728035/18001

[commit-bot: I haz the power, 2011-11-30 23:42:35]

Try job failure for 8728035-18001 (retry) (retry) on linux_rel for step
"compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-30 23:45:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/8728035/18001

[commit-bot: I haz the power, 2011-12-01 01:54:36]

Change committed as 112372