Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 8728023: (Cleanup) Use its own MIME type in the PPAPI IME example. (Closed)

Created:
9 years ago by kinaba
Modified:
9 years ago
Reviewers:
brettw, kochi
CC:
chromium-reviews
Visibility:
Public.

Description

(Cleanup) Use its own MIME type in the PPAPI IME example. As other examples do, use own MIME type instead of application/x-ppapi-example. BUG=none TEST=make ppapi_example_ime, and verify the following command loads the example. chrome \ --register-ppapi-plugins="/path/to/libppapi_example_ime.so;application/x-ppapi-example-ime" \ file:///path/to/ppapi/examples/ime.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114371

Patch Set 1 #

Patch Set 2 : Wrapped >80 letter lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M ppapi/examples/ime/ime.html View 1 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kinaba
9 years ago (2011-11-29 04:49:58 UTC) #1
kochi
LGTM
9 years ago (2011-11-29 10:33:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/8728023/1002
9 years ago (2011-11-29 10:43:12 UTC) #3
commit-bot: I haz the power
Presubmit check for 8728023-1002 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-11-29 10:43:14 UTC) #4
kinaba
Brett, could you take a look and give me an owner's lgtm? Thanks!
9 years ago (2011-11-29 10:51:43 UTC) #5
kinaba
Brett: ping. This CL is just a clean-up and has almost nothing to see, but ...
9 years ago (2011-12-13 06:13:56 UTC) #6
brettw
lgtm
9 years ago (2011-12-13 15:20:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/8728023/1002
9 years ago (2011-12-14 02:56:02 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-14 06:03:17 UTC) #9
Change committed as 114371

Powered by Google App Engine
This is Rietveld 408576698