LayoutTests/media/video-scales-in-media-document.html - Issue 8728018: Resize MediaDocument playback to fit window size.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-scales-in-media-document.html

Issue 8728018: Resize MediaDocument playback to fit window size. (Closed) Base URL: http://git.chromium.org/external/WebKit_trimmed.git@master

Patch Set: Via CSS + Layout test. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="media-file.js"></script>

	4 <script src="video-test.js"></script>

	5 <script>

	6 function timeupdate(event) {

	7 var video = event.target;

	8 testExpected(video.offsetWidth, 200);

	9 testExpected(video.offsetHeight, 163);

	10 endTest();

	11 }

	12

	13 function iframeLoad() {

	14 var iframe = document.getElementById("container");
	scherkus (not reviewing) 2011/12/06 02:19:53 instead of using IDs just use querySelector('ifram instead of using IDs just use querySelector('iframe') DaleCurtis 2011/12/06 21:13:45 Interesting, I haven't used that before. By the nu Interesting, I haven't used that before. By the numbers querySelector performs much worse than getElementById: http://jsperf.com/getelementbyid-vs-queryselector Not that it matters for this test, but I'm curious to hear your thoughts. Done. scherkus (not reviewing) 2011/12/08 06:43:51 ids are unique in a document and as you might imag Show quoted text On 2011/12/06 21:13:45, DaleCurtis wrote: > Interesting, I haven't used that before. By the numbers querySelector performs > much worse than getElementById: > > http://jsperf.com/getelementbyid-vs-queryselector > > Not that it matters for this test, but I'm curious to hear your thoughts. Done. ids are unique in a document and as you might imagine could be implemented via hash lookup querySelector() requires a traversal of the DOM but I like using it for tests as you don't need to muck around with ids and I've found it to be less brittle as tests get updated
	15 var video = iframe.contentDocument.querySelector("video");

	16 video.addEventListener("timeupdate", timeupdate);
	scherkus (not reviewing) 2011/12/06 02:19:53 use canplay instead of timeupdate use canplay instead of timeupdate DaleCurtis 2011/12/06 21:13:45 Done. Show quoted text On 2011/12/06 02:19:53, scherkus wrote: > use canplay instead of timeupdate Done.
	17 }

	18

	19 function load() {

	20 var iframe = document.getElementById("container");

	21 iframe.onload = iframeLoad;

	22 iframe.src = findMediaFile("video", "content/counting");

	23 }

	24 </script>

	25 </head>

	26

	27 <body onload="load()">

	28 <p>Test that video media documents scale to fit undersized containers.</ p>

	29 <iframe style="width: 200px; height: 200px; border: 0px; overflow: scrol l;" id="container"></iframe>

	30 </body>

	31 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/video-scales-in-media-document-expected.txt » ('j') | no next file with comments »