Add a presubmit check so that no new unit tests in content/ are added to the unit_tests target

Add a presubmit check so that no new unit tests in content/ are added to the unit_tests target

They should all go to content_unittests now

BUG=90443
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111925

[jochen (gone - plz use gerrit), 2011-11-28 22:41:35]

plz review

[jam, 2011-11-28 23:18:54]

this looks great to me, but I haven't written python in such a long time. i
should defer this to someone else, i.e. joi/maruel/dirk

[Jói, 2011-11-29 09:10:29]

LGTM with the following issues addressed.

http://codereview.chromium.org/8728012/diff/1/chrome/PRESUBMIT.py
File chrome/PRESUBMIT.py (right):

http://codereview.chromium.org/8728012/diff/1/chrome/PRESUBMIT.py#newcode5
chrome/PRESUBMIT.py:5: import re
Please improve the docstring rather than removing it (it was at line 5 in the
original version of the file).

http://codereview.chromium.org/8728012/diff/1/chrome/PRESUBMIT.py#newcode68
chrome/PRESUBMIT.py:68: '\n'.join(problems))]
There is another constructor for a message followed by a list of items, that
will format this more nicely.

You can then skip prepending spaces in line 61, and call the constructor like
this (IIRC; check depot_tools/presubmit_support.py if I'm wrong):

  return [output_api.PresubmitPromptWarning(
       'Unit tests located in content/ should be added to the ' +
       'content_tests.gypi:content_unittests target.',
       problems)]

[jochen (gone - plz use gerrit), 2011-11-29 13:01:11]

http://codereview.chromium.org/8728012/diff/1/chrome/PRESUBMIT.py
File chrome/PRESUBMIT.py (right):

http://codereview.chromium.org/8728012/diff/1/chrome/PRESUBMIT.py#newcode5
chrome/PRESUBMIT.py:5: import re
On 2011/11/29 09:10:30, Jói wrote:
> Please improve the docstring rather than removing it (it was at line 5 in the
> original version of the file).

Done.

http://codereview.chromium.org/8728012/diff/1/chrome/PRESUBMIT.py#newcode68
chrome/PRESUBMIT.py:68: '\n'.join(problems))]
On 2011/11/29 09:10:30, Jói wrote:
> There is another constructor for a message followed by a list of items, that
> will format this more nicely.
> 
> You can then skip prepending spaces in line 61, and call the constructor like
> this (IIRC; check depot_tools/presubmit_support.py if I'm wrong):
> 
>   return [output_api.PresubmitPromptWarning(
>        'Unit tests located in content/ should be added to the ' +
>        'content_tests.gypi:content_unittests target.',
>        problems)]

Done.