base/bind_internal.h.pump - Issue 8728010: Increase Bind/Callback Arity from 6 -> 7. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(498)

My Issues | Starred Open | Closed | All

Unified Diff: base/bind_internal.h.pump

Issue 8728010: Increase Bind/Callback Arity from 6 -> 7. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated comments. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« base/bind_internal.h ('K') | « base/bind_internal.h ('k') | base/bind_internal_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/bind_internal.h.pump

diff --git a/base/bind_internal.h.pump b/base/bind_internal.h.pump

index 1192974455f4c63b68bc499fb34c8cf13177403e..53dcbd3a618c71a9336e44563e92645c8c6eca38 100644

--- a/base/bind_internal.h.pump

+++ b/base/bind_internal.h.pump

@@ -5,13 +5,8 @@ $$

$$ http://code.google.com/p/googletest/wiki/PumpManual

$$

-// TODO(ajwong): If you create an fully unbound method, is there a way to

-// enforce the first argument must be refcounted? Or do we just say

-// "oh well"?

-//

-// Do we want to allow creating a fully unbound method??

-

-$var MAX_ARITY = 6

+$$ See comment for MAX_ARITY in base/bind.h.pump.

+$var MAX_ARITY = 7

$range ARITY 0..MAX_ARITY

// Copyright (c) 2011 The Chromium Authors. All rights reserved.

« base/bind_internal.h ('K') | « base/bind_internal.h ('k') | base/bind_internal_win.h » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698